[DEVIN: Konsti] Fix failing E2E tests: CLI error string and MCP prompt name#1439
Conversation
- cli.test.ts: Update expected error from 'File not found' to 'Config file not found' to match actual CliError message - mcp.test.ts: Update expected prompt name from 'ask_stack_auth' to 'skill' to match MCP handler implementation Co-Authored-By: Konstantin Wohlwend <n2d4xc@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR fixes two E2E test assertions that were mismatched against their implementations. Both corrections are verified against the source code they test.
Confidence Score: 5/5Both test fixes are straightforward assertion corrections verified against the actual implementation — safe to merge. Each changed assertion was confirmed against the source it tests: the CLI error string matches the exact CliError message in config-file-path.ts, and 'skill' matches the prompt name registered in mcp-handler.ts. No logic, no runtime paths, and no application code are modified. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant Test as E2E Test
participant CLI as stack-cli (init --mode link-config)
participant CFP as config-file-path.ts
participant MCP as mcp-handler.ts
Note over Test,CFP: CLI test fix
Test->>CLI: run with --config-file /nonexistent/stack.config.ts
CLI->>CFP: "resolveConfigFilePathOption(path, {mustExist: true})"
CFP-->>CLI: throw CliError("Config file not found: ...")
CLI-->>Test: stderr contains "Config file not found" ✓
Note over Test,MCP: MCP test fix
Test->>MCP: prompts/list request
MCP-->>Test: "[{name: "skill"}]"
Test->>Test: "assert name === "skill" ✓"
Reviews (1): Last reviewed commit: "Fix failing E2E tests: update CLI error ..." | Re-trigger Greptile |
…ation The resources/list assertion still expected the old 'stack-auth-mcp-setup' name and 'stack-auth://mcp/setup' URI, but the MCP handler now registers the resource as 'skill' with URI 'https://skill.stack-auth.com'. Co-Authored-By: Konstantin Wohlwend <n2d4xc@gmail.com>
|
Devin is archived and cannot be woken up. Please unarchive Devin if you want to continue using it. |
Fixes three deterministic E2E test failures on the dev branch:
CLI test (
apps/e2e/tests/general/cli.test.ts:611): The test expected'File not found'but the actualCliErrormessage is'Config file not found: ...'. Updated to match the real error message frompackages/stack-cli/src/lib/config-file-path.ts.MCP prompt test (
apps/e2e/tests/backend/endpoints/api/v1/internal/mcp.test.ts:114): Theprompts/listtest expected prompt name'ask_stack_auth'but the MCP handler registers the prompt as'skill'(apps/mcp/src/mcp-handler.ts:93-94). Updated to match.MCP resource test (
mcp.test.ts:131-132): Theresources/listtest expected resource name'stack-auth-mcp-setup'with URI'stack-auth://mcp/setup', but the handler now registers the resource as'skill'with URI'https://skill.stack-auth.com'(apps/mcp/src/mcp-handler.ts:76-78). Updated to match.These failures were consistent across all E2E test workflows (regular, local emulator, custom port prefix). Other CI failures in the setup-tests and DB-migration-compat workflows appear to be flaky/timeout-related and also occur on the base branch.
Link to Devin session: https://app.devin.ai/sessions/5ee786b351194d4fb24b150fd358d6f5
Requested by: @N2D4