Skip to content

fix: ensure Content-Type is set when sending JSON with custom headers #1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zafar1162014 wants to merge 1 commit into from
+6 −0
Closed

fix: ensure Content-Type is set when sending JSON with custom headers #1840

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions httpie/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,12 @@ def make_request_kwargs(
if base_headers:
headers.update(base_headers)
headers.update(args.headers)
# Ensure Content-Type is set for JSON requests even if user headers
# were provided. This fixes the case where a single custom header
# prevents the default Content-Type from being preserved.
# See: https://github.com/httpie/cli/issues/1834
if auto_json and 'Content-Type' not in headers:
headers['Content-Type'] = JSON_CONTENT_TYPE
Comment on lines +347 to +352
Comment thread
zafar1162014 marked this conversation as resolved.
if args.offline and args.chunked and 'Transfer-Encoding' not in headers:
# When online, we let requests set the header instead to be able more
# easily verify chunking is taking place.
Expand Down
Loading