Skip to content

feat: fetch repository sbom #2187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Anonycoders wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: fetch repository sbom #2187

Anonycoders wants to merge 1 commit into from
+2,440 −1

Conversation

@Anonycoders
Copy link
Contributor

@Anonycoders Anonycoders commented Jan 25, 2026 •
edited
Loading

Description

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site "-Dsurefire.argLine=--add-opens java.base/java.net=ALL-UNNAMED" locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@codecov
Copy link

codecov bot commented Jan 25, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 90.90909% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.07%. Comparing base (9152b37) to head (1f1af7f).

Files with missing lines Patch % Lines
src/main/java/org/kohsuke/github/GHSBOM.java 89.18% 0 Missing and 4 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #2187      +/-   ##
============================================
+ Coverage     85.03%   85.07%   +0.03%     
- Complexity     2499     2512      +13     
============================================
  Files           237      239       +2     
  Lines          7366     7409      +43     
  Branches        388      390       +2     
============================================
+ Hits           6264     6303      +39     
  Misses          871      871              
- Partials        231      235       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

bitwiseman
bitwiseman reviewed Feb 10, 2026
View reviewed changes
src/main/java/org/kohsuke/github/GHSBOM.java
*/
public static class ExternalRef {

@JsonProperty("referenceCategory")
Copy link
Member

@bitwiseman bitwiseman Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these @JsonProperty() annotations needed?

Copy link
Contributor Author

@Anonycoders Anonycoders Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bitwiseman For this specific case (haven't checked all GH endpoints) the @JsonProperty is needed because Jackson mapper is globally set to PropertyNamingStrategies.SNAKE_CASE and this specific endpoint returns camelCase!

I see you have already approved the PR but I'm still not sure if I'm allowed to merge or not. Would leave it here until you are back and let me know if in such cases I can continue with merge or not. thank you for your time and effort! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bitwiseman bitwiseman bitwiseman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

How to extract the dependencies of a repository?

2 participants

@Anonycoders @bitwiseman