Skip to content

docs: improve docstring scheduling_sasolver.py#14148

Merged
stevhliu merged 5 commits into
huggingface:mainfrom
delmalih:improve-docstring-scheduling-sasolver
Jul 10, 2026
Merged

docs: improve docstring scheduling_sasolver.py#14148
stevhliu merged 5 commits into
huggingface:mainfrom
delmalih:improve-docstring-scheduling-sasolver

Conversation

@delmalih

@delmalih delmalih commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR improves the docstrings and type hints in src/diffusers/schedulers/scheduling_sasolver.py to follow the project conventions as described in #9567.
Fixes #9567

Context

This is part of a broader effort to improve documentation across all scheduler files in src/diffusers/schedulers/. See issue #9567 for details.

Testing

  • Code passes make style
  • Code passes make quality
  • Code passes make fix-copies
  • Existing tests still pass

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline?
  • Did you read our philosophy doc (important for complex PRs)?
  • Was this discussed/approved via a GitHub issue or the forum? issue.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? (N/A - documentation only changes)

Who can review?

cc @stevhliu for review

@github-actions github-actions Bot added schedulers size/M PR with diff < 200 LOC fixes-issue labels Jul 9, 2026
@delmalih delmalih force-pushed the improve-docstring-scheduling-sasolver branch from b422e30 to 85360e6 Compare July 9, 2026 10:53

@stevhliu stevhliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Comment thread src/diffusers/schedulers/scheduling_sasolver.py Outdated
Comment thread src/diffusers/schedulers/scheduling_sasolver.py Outdated
Comment thread src/diffusers/schedulers/scheduling_sasolver.py Outdated
Comment thread src/diffusers/schedulers/scheduling_sasolver.py Outdated
delmalih and others added 4 commits July 10, 2026 00:35
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu stevhliu merged commit e276555 into huggingface:main Jul 10, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[community] Improving docstrings and type hints

3 participants