Skip to content

The default "useLinkCard" setting should be false, not true #10

Description

@gtjoseph

With the current default of "true", the module attempts to download all links in the source document including things like tarballs. The result is either renderAsync() returning a 500 if some of links can't be found (but doesn't tell you which ones) or a mess of a document.

Here's an example:

 - [Full ChangeLog](https://downloads.asterisk.org/pub/telephony/asterisk/releases/ChangeLog-18.19.0.md)  
 - [GitHub Diff](https://github.com/asterisk/asterisk/compare/18.18.1...18.19.0)  
 - [Tarball](https://downloads.asterisk.org/pub/telephony/asterisk/asterisk-18.19.0.tar.gz)  
 - [Downloads](https://downloads.asterisk.org/pub/telephony/asterisk)  

image

Even if it were working, the default should NOT automatically try to download links.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions