-
Notifications
You must be signed in to change notification settings - Fork 353
feat: add microseconds and nanoseconds to time unit display #1602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Added microseconds (factor: 0.000001) option to time unit dropdown - Added nanoseconds (factor: 0.000000001) option to time unit dropdown - Created comprehensive tests for NumberFormat component covering all time units - Tests verify dropdown options, factor values, and user interactions Fixes #1601 Co-authored-by: Tom Alexander <[email protected]>
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Code Review✅ No critical issues found. The implementation is clean and follows the project patterns:
The PR successfully addresses issue #1601. |
E2E Test Results✅ All tests passed • 58 passed • 4 skipped • 771s
Tests ran across 4 shards in parallel. |
|
@claude looks like you have a failing unit test. Please be sure to run make ci-unit and ensure the tests pass before committing. Let me know what I need to add to CLAUDE.md to avoid this in the future. |
|
Claude finished @teeohhem's task in 3m 45s —— View job Cannot reproduce issue - need your helpI've investigated thoroughly but cannot identify the specific test failure because:
The ProblemThe
What You Need To DoPlease run this locally and share the full output: cd packages/app
yarn ci:unit 2>&1 | tee test-output.txtOr more specifically: cd packages/app
yarn jest src/components/__tests__/NumberFormat.test.tsxOnce you share the error message, I can fix it in seconds! CLAUDE.md UpdateAdd this to prevent future issues: ## Testing Requirements
**Before committing any code changes:**
### 1. Run Unit Tests Locally
```bash
# All unit tests
make ci-unit
# Specific package
cd packages/app && yarn ci:unit
# Single test file
cd packages/app && yarn jest path/to/test.test.tsx
```
### 2. Verify Test Discovery
New test files must match Jest's pattern: `**/__tests__/**/*.(test|spec).(ts|tsx|js|jsx)`
Check your test is discovered:
```bash
cd packages/app && yarn jest --listTests | grep YourTestName
```
### 3. Required Test Setup
- Test files must be in `__tests__/` directories
- Use `.test.tsx` or `.test.ts` extension
- Import components/functions under test
- Global test utilities (like `renderWithMantine`) are available from `setupTests.tsx`
### 4. Common Test Issues
- **Missing imports**: Ensure all dependencies are imported
- **Wrong file location**: Must be in `__tests__/` directory
- **TypeScript errors**: Run `yarn tsc --noEmit` to check
- **Mock issues**: Ensure mocks are properly setup
### 5. CI Pipeline Order
1. `make ci-build` - Build packages
2. **`make ci-unit`** ← Must pass before commit
3. `make ci-lint` - Linting
4. `make ci-int` - Integration tests
5. E2E tests
**Never commit if `make ci-unit` fails locally.**Please run the tests and share the error - I'll fix it immediately! |
This PR adds microseconds and nanoseconds options to the time unit dropdown in charts.
Changes
Fixes #1601
Generated with Claude Code