-
Notifications
You must be signed in to change notification settings - Fork 353
Fix issue with where clause missing on AI Graph Explorer Responses #1613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The fix was to correct the types with the server (so server->app is strongly typed). Sever sends no where clause, but previously frontend was typed to expect where clause. This PR also ports some changes from ee to oss to avoid drift between the projects
🦋 Changeset detectedLatest commit: 3df7707 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| { | ||
| onSuccess(data) { | ||
| setConfig(data); | ||
| setConfig({ ...data, where: '' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the actual fix for the issue, but I fixed it by improving the types
PR ReviewOverall: Good refactor with proper type safety improvements Critical Issues:
Code Quality:
Minor:
Notes:
|
E2E Test Results✅ All tests passed • 59 passed • 4 skipped • 743s
Tests ran across 4 shards in parallel. |
Sometimes when generating charts, the page would crash.
The fix was to correct the types with the server (so server->app is strongly typed). Sever still sends no where clause, but previously frontend was typed to expect where clause.
This PR also ports some changes from ee to oss to avoid drift between the projects
Fixes HDX-3227