Skip to content

fix: Fix error when saving Dashboards with null numberFormat#1643

Closed
pulpdrew wants to merge 1 commit intomainfrom
drew/fix-null-numberformat-tile-save
Closed

fix: Fix error when saving Dashboards with null numberFormat#1643
pulpdrew wants to merge 1 commit intomainfrom
drew/fix-null-numberformat-tile-save

Conversation

@pulpdrew
Copy link
Contributor

@pulpdrew pulpdrew commented Jan 22, 2026

Summary

This PR fixes a bug that causes an error when saving a dashboard after removing a numberFormat from a tile, due to a null value instead of the expected undefined. The possibility of a null value was introduced in #1617, to allow react-hook-form to clear the number format.

@changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2026

🦋 Changeset detected

Latest commit: a5e8102

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hyperdx/common-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
hyperdx-v2-oss-app Error Error Jan 22, 2026 7:15pm

Request Review

@claude
Copy link

claude bot commented Jan 22, 2026

✅ No critical issues found.

The fix correctly addresses the schema validation issue by allowing numberFormat to accept null values in addition to undefined. This aligns with react-hook-form's behavior when clearing form values.

Minor suggestion (optional):

  • Consider adding a unit test in packages/common-utils that validates the schema accepts both null and undefined for numberFormat to prevent regression.

@github-actions
Copy link
Contributor

E2E Test Results

All tests passed • 0 passed • 0 skipped • 83s

Status Count
✅ Passed 0
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 0

Tests ran across 4 shards in parallel.

View full report →

@pulpdrew pulpdrew changed the title fix: Fix error when saving new Dashboard tile due to null numberFormat fix: Fix error when saving Dashboards with null numberFormat Jan 22, 2026
@pulpdrew pulpdrew closed this Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant