fix: Fix error when saving Dashboards with null numberFormat#1643
Closed
fix: Fix error when saving Dashboards with null numberFormat#1643
Conversation
🦋 Changeset detectedLatest commit: a5e8102 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
✅ No critical issues found. The fix correctly addresses the schema validation issue by allowing Minor suggestion (optional):
|
Contributor
E2E Test Results✅ All tests passed • 0 passed • 0 skipped • 83s
Tests ran across 4 shards in parallel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug that causes an error when saving a dashboard after removing a numberFormat from a tile, due to a null value instead of the expected undefined. The possibility of a null value was introduced in #1617, to allow react-hook-form to clear the number format.