JHEMCUF435: enable UART2#11597
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Branch Targeting SuggestionYou've targeted the
If This is an automated suggestion to help route contributions to the appropriate branch. |
|
Thanks for the detailed description and history! Have you tested it with the hardware? My description of #10840 suggests I may have tested it with this board, but forgot to update the target file. |
|
Test firmware build ready — commit Download firmware for PR #11597 1 targets built. Find your board's
|
@sensei-hacker yes it works well. Sorry for late response.
9e6c1ba4-acdc-44ca-a96b-58c30ab7bac7.mp4 |

JHEMCUF435: enable UART2
Summary
This PR enables UART2 on the
JHEMCUF435target and updatesSERIAL_PORT_COUNTaccordingly.UART2 was already documented in the target file, but it was left commented out with this note:
The target already contained the intended UART2 mapping:
PB0,UART2_RX_AF 6PA8,UART2_TX_AF 8This PR restores that mapping and increases
SERIAL_PORT_COUNTfrom8to9because the target now exposes:Rationale
The original UART2 comment appears to refer to an AT32F43x UART driver issue that has since been fixed.
Relevant history:
51d98cffeadded support for specifying AT32 UART RX/TX alternate functions independently.uart->rx_afinstead ofuart->tx_af.a941b14a8/ PR #10840 (f435 correct uart->tx_af), changing the TX configuration to use the correctuart->tx_afvalue.JHEMCUF435AIOwas then updated in9b43222eeto use the same UART2 alternate-function mapping style:UART2_RX_AF 6UART2_TX_AF 8UART2_RX_PIN PB0UART2_TX_PIN PA8Related target history:
JHEMCUF435was added in5283cd7c9, merged via PR #10825. This is where the commented UART2 block and the “software issue” note were introduced.JHEMCUF435AIOwas added via PR #10740, and later received the UART2 AF update above.Because the current AT32F43x serial driver now correctly applies
uart->tx_afto TX pins, the earlier software limitation should no longer apply.Notes for reviewers
This PR only changes the
JHEMCUF435target configuration. It does not modify common serial driver code.The only remaining point to verify is hardware-level confirmation that the non-AIO
JHEMCUF435board routes the TX2 pad to MCU pinPA8. The mapping itself matches the existing target comments and the relatedJHEMCUF435AIOconfiguration pattern.