feat(decompiler): link override keyword to base member definition#3741
Open
leno23 wants to merge 1 commit into
Open
feat(decompiler): link override keyword to base member definition#3741leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
Make the override modifier a navigation hyperlink to the nearest overridden member, matching Visual Studio go-to-definition behavior. Also fix a duplicate "to" typo in ilspycmd --generate-diagrammer help. Fixes icsharpcode#2035
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2035
When decompiling C# with syntax highlighting enabled, the
overridemodifier is now emitted as a hyperlink to the nearest overridden member (viaInheritanceHelper.GetBaseMember), similar to Visual Studio go-to-definition onoverride.Implementation is in
TextTokenWriter.WriteKeyword, alongside the existingthis/baseconstructor-initializer references.Also fixes a duplicate word typo (
next to to→next to the) inilspycmd --generate-diagrammerhelp text.Test plan
overrideand confirm navigation to the base memberI do not have a local .NET SDK in this environment; changes were not built locally.
Made with Cursor