Avoid repeating duplicate links for screen readers on search page, recommended lists pages, poll pages, etc.#1376
Open
alice-blue wants to merge 6 commits into
Conversation
…on't hear the same link twice in a row (image and title)
…er art links so screenreader users don't hear the same link twice in a row (image link, then title link)
… links and avoid reading the url of the image link
…for duplicate image links
… image links rather than having the screenreader announce the image URL
…ended games instead of having screen readers announce the url
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IFDB has lists of games with a cover art link beside a game title link, and with both links leading to the same destination. This kind of thing can cause redundancy for screen readers:
(Discussed here)
Right now, it looks like the alt text is set to "" for the thumbnails, but according to Webaim.org :
As suggested by an IFDB user and this page, one way of addressing this is to use
aria-hidden="true" tabindex="-1on the anchor element of the image link.This PR make this change for:
This PR partly addresses #1377.