Show rating boxes in search page#1383
Draft
salty-horse wants to merge 9 commits into
Draft
Conversation
Contributor
If there is a way to not show the "Have you played this game" heading on the widget, and instead put "Rate it" at the top of the box, that might save a little vertical space. |
07d16b2 to
0a83cd6
Compare
Collaborator
Author
0a83cd6 to
0bcbf94
Compare
Collaborator
Author
0bcbf94 to
97f7bb4
Compare
Contributor
Is there a way to make the game boxes all the same width so that the rating boxes all line up with each other? Or if the tip boxes are in the way, maybe those could be hidden when ratings boxes are visible. |
Collaborator
Author
|
I'll hide the tip boxes, and try to fix the difference in width when there's a long game title. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





This addresses #761.
I added a "show rating boxes" checkbox to the top of the search page.
In the background, the page always loads with all the boxes, but they're hidden. Clicking the checkbox shows/hides them, and updates the address bar and the pagination links to include/remove the new query parameter.
rating_boxes.mp4
I think I tested all the features in the rating box (not shown in video: setting playing times), and also made sure the regular game page still works.
Open issues: