feat(reactotron-app): Network tab with api responses#1471
Open
finalquest wants to merge 1 commit intoinfinitered:masterfrom
Open
feat(reactotron-app): Network tab with api responses#1471finalquest wants to merge 1 commit intoinfinitered:masterfrom
finalquest wants to merge 1 commit intoinfinitered:masterfrom
Conversation
|
Hello 👋 Do you have a preview image of the effect |
Author
|
That looks great! Makes sense to give network requests its own tab and a separate panel for details. |
|
Looks like this is a duplicate of #1426 though. |
Member
|
I do like the idea here, @finalquest, but since it looks like you're pulling in #1426 and building on that, we should leave their commits in to credit them for the work they've done. Regardless, I'm not sure that I'll accept this as-is. Will do some thinking about this. I think it's a good idea, but the implementation here might need some more thought. |
|
This is really good idea, please take a look |
Member
|
I do think it's a good idea. I'm focused on a rewrite of Reactotron right now, but I'll keep this in mind for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Please verify the following:
yarn build-and-test:localpassesREADME.md(or relevant documentation) has been updated with your changesDescribe your PR
I made a new network tab to group the api.responses messages.
Made a custom command to clear all the commands that are/not are api.
Removed the api filter from the Timeline modal
Next Steps
This changes only moved the rendered cell to another list.
I think that the command list should be splitted in commands and networkCommands.
The current solution works over the full command list.
Maybe we should make a right sidebar with all the header/request/response. Something like Flipper have