Skip to content

ci: fix test xml result generate#152

Merged
bednar merged 1 commit intomasterfrom
ci/fix-junit-result
Mar 9, 2026
Merged

ci: fix test xml result generate#152
bednar merged 1 commit intomasterfrom
ci/fix-junit-result

Conversation

@NguyenHoangSon96
Copy link
Contributor

@NguyenHoangSon96 NguyenHoangSon96 commented Mar 6, 2026

Closes #

Proposed Changes

  • Switches the JRuby jobs from jruby:9.3.1.0-jdk11 to jruby:9.4-dev-jdk11.
  • Adds a conditional step to install git only when using the jruby:9.4-dev-jdk11 Docker image.
  • Ensures perl is installed before running the Codecov uploader verification steps (the workflow uses shasum, which depends on perl on Debian/Ubuntu images).
  • Adds a monkeypatch for REXML::Document#initialize to tolerate malformed XML emitted during Cobertura report formatting.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • rake test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Mar 6, 2026
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.18%. Comparing base (1bc4c39) to head (b0a9e3d).
⚠️ Report is 1 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
- Coverage   48.23%   48.18%   -0.05%     
==========================================
  Files          77       77              
  Lines        7948     7923      -25     
==========================================
- Hits         3834     3818      -16     
+ Misses       4114     4105       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NguyenHoangSon96 NguyenHoangSon96 added this to the 3.3.0 milestone Mar 9, 2026
@NguyenHoangSon96 NguyenHoangSon96 marked this pull request as ready for review March 9, 2026 02:40
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bednar bednar merged commit 6c6a9af into master Mar 9, 2026
17 checks passed
@bednar bednar deleted the ci/fix-junit-result branch March 9, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants