Conversation
Collaborator
🪡 Patchwork previewTorn down. |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Incremental edit counting can misclassify operations within subsequently deleted metadata objects.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Reduces persistent draft bookkeeping and makes timeline grouping lazy and more efficient.
Changes:
- Reuses checkout documents and lazily creates draft metadata.
- Reworks actor attribution and change grouping around operation counts.
- Updates Patchwork dependencies and adds edit-count tests.
| File | Description |
|---|---|
drafts/src/providers/DraftStateProvider.ts |
Lazily manages draft state, grouping, and attribution. |
drafts/src/DraftsSidebar.tsx |
Prevents writes after sidebar disposal. |
drafts/src/change-group-cache.ts |
Introduces operation-based edit counting and caching. |
drafts/src/change-group-cache.test.ts |
Tests operation counts against diff counts. |
drafts/src/actor-attribution.ts |
Watches writable documents for attributable edits. |
drafts/package.json |
Updates Patchwork dependencies. |
drafts/pnpm-lock.yaml |
Locks updated dependency graph. |
Files not reviewed (1)
- drafts/pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+177
to
+178
| const skipObjs = new Set<string>(); | ||
| objectIdsUnder((doc as Record<string, unknown>)["@patchwork"], skipObjs); |
chee
marked this pull request as ready for review
September 23, 2026 10:07
paulsonnentag
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
don't do some much draftsting when drafts isn't open