Presenter: auto-reconnect when the presenter window is refreshed#8
Open
LeaVerou wants to merge 1 commit into
Open
Presenter: auto-reconnect when the presenter window is refreshed#8LeaVerou wants to merge 1 commit into
LeaVerou wants to merge 1 commit into
Conversation
The projector window already reconnected on refresh via its persistent
window.name ("projector") and window.opener reference. The presenter
window had neither, so refreshing it lost the link to the projector and
required pressing Ctrl+P again.
Name the presenter window "presenter" when entering presenter mode so
that on reload it can identify itself and re-acquire the existing
projector via a named-window lookup (open("", "projector")), which
returns the existing window without reloading it. Both windows now
reconnect automatically on refresh and re-link each other's references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The projector window already reconnected on refresh via its persistent
window.name ("projector") and window.opener reference. The presenter
window had neither, so refreshing it lost the link to the projector and
required pressing Ctrl+P again.
Name the presenter window "presenter" when entering presenter mode so
that on reload it can identify itself and re-acquire the existing
projector via a named-window lookup (open("", "projector")), which
returns the existing window without reloading it. Both windows now
reconnect automatically on refresh and re-link each other's references.