Default the pytest asyncio fixture loop scope#662
Merged
booxter merged 1 commit intoinstructlab:mainfrom Jun 9, 2025
Merged
Conversation
Contributor
Author
Contributor
Author
|
Ignore the e2e-medium failure - it ran out of disk space and we haven't merged the latest xfs retries (#655) to help that yet. |
Fixes `INTERNALERROR` spam from pytest when run under unitcov - things like: ``` INTERNALERROR> pytest.PytestDeprecationWarning: The configuration option "asyncio_default_fixture_loop_scope" is unset. INTERNALERROR> The event loop scope for asynchronous fixtures will default to the fixture caching scope. Future versions of pytest-asyncio will default the loop scope for asynchronous fixtures to function scope. Set the default fixture loop scope explicitly in order to avoid unexpected behavior in the future. Valid fixture loop scopes are: "function", "class", "module", "package", "session" ``` Signed-off-by: Ben Browning <bbrownin@redhat.com>
bbrowning
force-pushed
the
asyncio-pytest-fixture-default
branch
from
e5fb33f to
2d5048a
Compare
booxter
approved these changes
Jun 9, 2025
Contributor
|
The fix was applied in other repos. Merging with 1 vote to speed the fix up. |
Contributor
Author
|
@Mergifyio backport release-v0.8 |
Contributor
✅ Backports have been createdDetails
|
bbrowning
added a commit
that referenced
this pull request
Jun 9, 2025
Default the pytest asyncio fixture loop scope (backport #662)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
INTERNALERRORspam from pytest when run under unitcov - things like: