[raft/rid] Extract delete subscription - #1597
Merged
Merged
Conversation
MariemBaccari
marked this pull request as draft
July 13, 2026 07:00
MariemBaccari
force-pushed
the
delete_subscription_rid
branch
2 times, most recently
from
July 13, 2026 07:22
a17a1e9 to
0dceaef
Compare
MariemBaccari
marked this pull request as ready for review
July 13, 2026 07:26
barroco
added
the
dss-raft
MariemBaccari
force-pushed
the
delete_subscription_rid
branch
4 times, most recently
from
August 11, 2026 11:43
45621c9 to
864014e
Compare
This was referenced Aug 11, 2026
MariemBaccari
force-pushed
the
delete_subscription_rid
branch
from
August 11, 2026 13:17
864014e to
d7f2d24
Compare
MariemBaccari
force-pushed
the
delete_subscription_rid
branch
2 times, most recently
from
August 19, 2026 12:11
0b51ef7 to
3fb09e3
Compare
This was referenced Aug 19, 2026
mickmis
approved these changes
Aug 19, 2026
MariemBaccari
force-pushed
the
delete_subscription_rid
branch
from
August 19, 2026 13:56
3fb09e3 to
9198cab
Compare
MariemBaccari
force-pushed
the
delete_subscription_rid
branch
from
August 19, 2026 14:10
9198cab to
a466075
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chained PR: #1622 -> #1528 -> #1626 -> #1597 -> #1623 -> #1627 -> #1642 -> #1643
Extracts the
DeleteSubscriptionbusiness logic into the registry so it can later be executed by the Raftstore. This also allows us to remove theApplicationlayer.