[benchmarker] Add RID subscription actions - #1633
Open
BenjaminPelletier wants to merge 2 commits into
Open
Conversation
BenjaminPelletier
marked this pull request as ready for review
August 14, 2026 17:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds benchmarker actions to create and delete subscriptions. The specifications of the actions can be seen in configurations/actions/f3411.py and then the implementations are in engine/actions/f3411.py. I used the new isas_images.jsonnet configuration to generate the results here, and a re-verification run from last night produced this:
The approach to establish and clear subscriptions via actions is different from SCD is currently (where subscriptions are possibly attempted by every user) and I think this approach is much better -- I'm intending on changing the SCD approach to match this one as a backlog task.