Fix local ecosystem configuration defaults - #1655
Merged
BenjaminPelletier merged 2 commits intoAug 20, 2026
Merged
Conversation
BenjaminPelletier
marked this pull request as ready for review
August 20, 2026 20:24
barroco
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1652, I changed test_docker_fully_mocked.sh to use the newest DSS image with expected flags, but this results in the local ecosystem used for CI tests being different from the local ecosystem that a developer would bring up by default on their system. This PR attempts to fix the difference by making run_locally.sh the sole location for default ecosystem options. It also removes a value from documentation so that it won't fall out of sync with the implementation, nor need maintenance when the implementation changes.