-
Notifications
You must be signed in to change notification settings - Fork 13.4k
fix(header): show iOS condense header when app is in MD mode #30690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@ShaneK is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey @kumibrr! Thanks for this request! I hope you don't mind, I've modified your PR to remove the HTML file as we usually only use them for things that change a lot and we'll be checking on often. I've replaced it with a regression test that uses Hopefully we can get this merged and deployed soon. Thanks! |
brandyscarney
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! 🙂
Issue number: resolves #29929
What is the current behavior?
When forcing
mode=iosin a collapsible header,.header-collapse-condensewould still be applied from theheader.md.scssfile, leaving the collapsible header always hidden.What is the new behavior?
When forcing
mode=iosin a collapsible header, the.header-collapse-condensestyles from theheader.md.scssfile won't be applied, and the collapsible header will be visible.Does this introduce a breaking change?
Other information
Something worth mentioning is that this behavior only appears after initial load: if the route is loaded refreshing the page, the header will appear and work correctly, but navigating forth and back will apply both the .ios and .md style files.
I showcase this with a modal because It'll always display the broken hehavior.
Screen.Recording.2025-09-23.at.20.00.26.mp4
Screen.Recording.2025-09-23.at.20.03.07.mp4