Skip to content

Conversation

@burdiyan
Copy link

@burdiyan burdiyan commented Dec 7, 2025

This commit adds the peer.ID of the requesting peer to the context, which can be used downstream in the blockstore or other components used by Bitswap.

This could be very useful for custom logging, or accessing the peer ID in custom block stores.

This commit adds the peer.ID of the requesting peer to the context,
which can be used downstream in the blockstore or other components used by Bitswap.
@burdiyan burdiyan requested a review from a team as a code owner December 7, 2025 14:32
@hsanjuan
Copy link
Contributor

hsanjuan commented Dec 9, 2025

Triage:

  • We assume you have tested this and it works for you (the modified context ends up at the blockstore.Get() or blockstore.GetMany() layer) (we don't know if this is the case).
  • To accept this, we would need a test in bitswap with a mocked blockstore that reads back the peer ID from the context. Otherwise it is very likely that this will somehow break in a future refactor without anyone noticing.

@hsanjuan hsanjuan self-assigned this Dec 9, 2025
@hsanjuan hsanjuan added kind/enhancement A net-new feature or improvement to an existing feature need/author-input Needs input from the original author labels Dec 9, 2025
@lidel
Copy link
Member

lidel commented Jan 6, 2026

Triage notes:

@lidel lidel added status/blocked Unable to be worked further until needs are met need/author-input Needs input from the original author and removed need/author-input Needs input from the original author labels Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement A net-new feature or improvement to an existing feature need/author-input Needs input from the original author status/blocked Unable to be worked further until needs are met

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants