Add resourcelock package for coordinating access via Kubernetes leases
#151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix-kaestner
force-pushed
the
resourcelock
branch
2 times, most recently
from
f4d6170 to
f7437e2
Compare
hardikdr
added
the
area/metal-automation
felix-kaestner
force-pushed
the
resourcelock
branch
from
f7437e2 to
26e6312
Compare
felix-kaestner
force-pushed
the
main
branch
3 times, most recently
from
64984b9 to
f71555b
Compare
felix-kaestner
force-pushed
the
resourcelock
branch
3 times, most recently
from
7bf3325 to
e3ba929
Compare
felix-kaestner
force-pushed
the
resourcelock
branch
from
e3ba929 to
4b08e62
Compare
nikatza
approved these changes
Jan 16, 2026
This package introduces a `ResourceLocker` type which can be used to obtain a distributed lock, based on Kubernetes leases. Assisted-by: Claude Code
This option defaults to 1. Which is also the default used by controller-runtime, see https://github.com/kubernetes-sigs/controller-runtime/blob/0c3a9102bc0af27b969b17191e68e6f28ff12c23/pkg/controller/controller.go#L49
felix-kaestner
force-pushed
the
resourcelock
branch
from
4b08e62 to
7755b25
Compare
This patch makes use of the `ResourceLocker` instance to only perform a single operation on a network device, minimizing the rist for unexpected side-effects of multiple controllers performing configuration changes on a network device at the same time.
felix-kaestner
force-pushed
the
resourcelock
branch
from
7755b25 to
5fe340f
Compare
Merging this branch changes the coverage (2 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package introduces a
ResourceLockertype which can be used to obtain a distributed lock, based on Kubernetes leases.