Add build release jobs to standard github actions#116
Open
turegjorup wants to merge 6 commits intodevelopfrom
Open
Add build release jobs to standard github actions#116turegjorup wants to merge 6 commits intodevelopfrom
turegjorup wants to merge 6 commits intodevelopfrom
Conversation
rimi-itk
reviewed
Aug 11, 2025
Contributor
rimi-itk
left a comment
rimi-itk
left a comment
There was a problem hiding this comment.
I like this. Some comments added.
| - name: Composer install | ||
| run: | | ||
| docker network create frontend | ||
| docker compose run --rm --user=root phpfpm composer install --no-dev -o --classmap-authoritative |
Contributor
There was a problem hiding this comment.
When env.COMPOSE_USER is set to runner, we don't need --user=… here:
Suggested change
| docker compose run --rm --user=root phpfpm composer install --no-dev -o --classmap-authoritative | |
| docker compose run --rm phpfpm composer install --no-dev -o --classmap-authoritative |
Co-authored-by: Mikkel Ricky <[email protected]>
Co-authored-by: Mikkel Ricky <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add build release jobs to standard github actions