Vanilla Integration: Use getenv() instead of $_ENV for configuration access
#679
+35
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One reason is that `putenv()` won't update `$_ENV`, which breaks code that uses `$_ENV` to read the environment. For further reference, see - itsgoingd#675 - https://stackoverflow.com/questions/3780866/why-is-my-env-empty Thanks to original author DominicDetta <[email protected]>!
UlrichEckhardt
force-pushed
the
fix/use-getenv-for-config
branch
from
29ba9a6 to
6e1d71e
Compare
Owner
|
Thanks! |
| */ | ||
|
|
||
| 'enable' => isset($_ENV['CLOCKWORK_ENABLE']) ? $_ENV['CLOCKWORK_ENABLE'] : true, | ||
| 'enable' => getenv('CLOCKWORK_ENABLE') !== false ? getenv('CLOCKWORK_ENABLE') : false, |
There was a problem hiding this comment.
By default was enabled, now it's not. It is not obvious in this commit, may be this is a mistake?
Contributor
Author
There was a problem hiding this comment.
That was a mistake, I'm sure.
UlrichEckhardt
added a commit
to UlrichEckhardt/clockwork
that referenced
this pull request
Mar 7, 2024
This was changed to false by accident in PR itsgoingd#679.
UlrichEckhardt
added a commit
to UlrichEckhardt/clockwork
that referenced
this pull request
Mar 15, 2024
This was changed to false by accident in PR itsgoingd#679.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes from a discussion in #675 and fixes one obstacle to the Mezzio integration, but also a general bug that other code would be affected by. Thanks to original author @DominicDetta!