add option to omit white-only entries from repl history#6
Open
averynortonsmith wants to merge 1 commit intojathak:masterfrom
Open
add option to omit white-only entries from repl history#6averynortonsmith wants to merge 1 commit intojathak:masterfrom
averynortonsmith wants to merge 1 commit intojathak:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(edited first PR attempt to fix issue with branches)
I'm hoping to use this library for the repl of my language, Pointless. I wonder whether you'd consider pulling a small change I've made. My fork adds boolean param to the repl constructor that controls whether whitespace-only repl inputs are added to the repl history (set to true by default for backwards-compatibility). It's a nice option to have since most PL repls leave out blank lines.
Thanks for making this library btw -- it's just what I've been looking for!