Open
Conversation
|
@shubh10 It's good, but i need |
Author
|
Can you be more specific?
Stephen
… On Aug 30, 2017, at 4:36 PM, Nik Kov ***@***.***> wrote:
@shubh10 <https://github.com/shubh10> It's good, but i need grace feature.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#488 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMJI9xwZilLIvPars1DP05_5GOH15Oasks5sdcfdgaJpZM4OW82k>.
|
Also there are no blur effect for the background. And appearence animations. |
Author
|
graceTime is supported, almost at the top of the implementation file…
/*
* graceTime is the time (in seconds) that the invoked method may be run without
* showing the HUD. If the task finishes before the grace time runs out, the HUD will
* not be shown at all.
* This may be used to prevent HUD display for very short tasks.
* Defaults to 0 (no grace time).
*/
var graceTime:TimeInterval = 0.0
I’m not sure what you are referring to for blue effect and appearance animations, but anything that was marked deprecated in the objective-C version was not implemented.
Stephen
… On Aug 31, 2017, at 4:19 AM, Nik Kov ***@***.***> wrote:
/*
* Grace period is the time (in seconds) that the invoked method may be run without
* showing the HUD. If the task finishes before the grace time runs out, the HUD will
* not be shown at all.
* This may be used to prevent HUD display for very short tasks.
* Defaults to 0 (no grace time).
*/
@Property (assign, nonatomic) NSTimeInterval graceTime;
Also there are no blue effect for the background. And appearence animations.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#488 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMJI94m1fee9kc0gvMMt50jefJZNiJP5ks5sdmyWgaJpZM4OW82k>.
|
|
I'm playing with it. Thoughts... static func hideHUDFor(_ view: UIView, animated: Bool = true) -> Bool Why is the bezelview private? (rhetorical question) Good work. |
Author
|
On Oct 20, 2017, at 11:41 AM, Chris Van Buskirk ***@***.***> wrote:
I'm playing with it. Thoughts...
static func hideHUDFor(_ view: UIView, animated: Bool = true) -> Bool
Should probably have a discardableResult.
Agreed.
Why is the bezelview private? (rhetorical question)
That’s the way it is in the Objective-C version. This is an almost true port.
… Good work.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#488 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMJI9xGMSVoQQimKVTnTapeB-nlXaHFWks5suL8fgaJpZM4OW82k>.
|
|
Finally, you have several warnings to update. I implemented it and it's working well. |
|
Is anyone working on this PR or is it abandoned? |
Author
|
I am still actively using the library (in Swift) and am open to keeping the Swift part moving forward.
… On Nov 26, 2018, at 11:09 AM, tomaszmaciejko ***@***.***> wrote:
Is anyone working on this PR or is it abandoned?
I have several thoughts on this implementation and I can help with the PR review.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#488 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMJI96jf5PjYv-7dlJUOh-MksHrFZpL7ks5uzBJPgaJpZM4OW82k>.
|
|
I did a swift version of the MBProgressHUD: Wish for help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial commit of MBProgressHUD in swift.