APP-1540 - Added incremental application update support by remove-lab… #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
omrilo
force-pushed
the
feature/APP-1540
branch
from
671e5da to
ccbe411
Compare
asafgabai
added
the
safe to test
github-actions
bot
removed
the
safe to test
Contributor
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit d0fad61. ♻️ This comment has been updated with latest results. |
shayshim
reviewed
Jan 5, 2026
| if ctx.IsFlagSet(commands.AddLabelsFlag) { | ||
| addLabels, err := utils.ParseLabelKeyValuePairs(ctx.GetStringFlagValue(commands.AddLabelsFlag)) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
pls wrap the error with more context about the failure, i.e. "failed to parse add-labels"
(and similarly for other errors)
shayshim
reviewed
Jan 5, 2026
| return result, nil | ||
| } | ||
|
|
||
| func ParseLabelKeyValuePairs(flagValue string) ([]model.LabelKeyValue, error) { |
shayshim
approved these changes
Jan 5, 2026
asafgabai
added
the
safe to test
github-actions
bot
removed
the
safe to test
omrilo
force-pushed
the
feature/APP-1540
branch
from
d0fad61 to
76041b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…els and add-labels flags
mainbranch.go vet ./....go fmt ./....