Skip to content
This repository was archived by the owner on May 4, 2018. It is now read-only.

socks5-proxy won't compile under windows#1293

Open
agrandville wants to merge 7 commits intojoyent:masterfrom
agrandville:master
Open

socks5-proxy won't compile under windows#1293
agrandville wants to merge 7 commits intojoyent:masterfrom
agrandville:master

Conversation

@agrandville
Copy link
Copy Markdown

compile the sample under windows is not naturaly.
I propose several modifications to get this sample functional.

Comment thread samples/socks5-proxy/build.gyp Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably try placing this above the targets:

'variables': {
  'uv_library': 'static'
}

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all right

To compile the libuv dependency, uv_library must a be declared
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants