Change attach/detach logic on the root-port to use debounce counter - #2
Open
verylowfreq wants to merge 5 commits into
Open
Change attach/detach logic on the root-port to use debounce counter#2verylowfreq wants to merge 5 commits into
verylowfreq wants to merge 5 commits into
Conversation
Rework hcd_ch32_usbfs.c into an asynchronous single-engine scheduler: ISR-driven round-robin over a flat ep[] array keyed by (daddr,ep_num,dir), one transaction outstanding on the USBFS host engine, interrupt EPs paced to bInterval. This adds USB hub, multiple-simultaneous-device, and hotplug support that the prior single-device driver (hathach#2793) lacked. Attach and disconnect are self-driven from the SOF interrupt: hcd_init() enables SOF generation so the 1ms tick runs even with no device attached, and that tick polls DEV_ATTACH (a device present at power-up makes no DETECT edge) and the no-response disconnect counter. Hot-plug also takes the DETECT edge as a fast path. No application poll hook is required. Control transfers go through WCH's reference transaction layer (wch_usbfs_ll.c, USBFSH_CtrlTransfer), which reliably enumerates bus-powered hubs and a broad range of devices. Code derived from WCH's HOST_KM reference, (c) WCH; thin headers MIT. Stays MCU-portable via ch32_usbfs_reg.h: it selects ch32v20x.h/ch32v30x.h plus the matching _usb.h by CFG_TUSB_MCU, and the driver/LL include only that selector (no hardcoded MCU header). v20x's SDK lacks RCC_USBFSCLKConfig, so the LL defers USB clock-source setup to board_init() there (as v307 also does). Supports CH32V20x and CH32V307 from one driver.
tusb_mcu.h auto-enables CFG_TUH_WCH_USBIP_USBFS for v307 (mirroring the v20x block; v307 has no USBHS host IP, only USBFS). Wire the host sources into both the make (family.mk) and cmake (family.cmake) builds: v307 adds hcd_ch32_usbfs.c + wch_usbfs_ll.c, v20x adds wch_usbfs_ll.c (it already built the HCD). v307 BSP also routes the USBFS IRQ to tuh_int_handler (vector is USBFS_IRQHandler, not OTG_FS_IRQHandler) and bumps the linker stack; v20x's USBHD_IRQHandler -> tuh_int_handler wiring is unchanged.
A failed TU_ASSERT/TU_VERIFY runs ebreak unconditionally; on WCH QingKe cores the WCH-LinkE leaves the debug module enabled after flashing, so that ebreak soft-resets the chip instead of returning the error value. Since these asserts fire on recoverable events (NAK, transient enum hiccup), host enumeration hit reboot loops. No-op the breakpoint on CH32V20x/V307/F20x so the assert returns its error value as on ARM.
RobertDaleSmith
force-pushed
the
ch32v307-usbfs-host
branch
3 times, most recently
from
June 23, 2026 05:00
434051d to
34f3170
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the root-port attach/detach logic in the WCH CH32 USBFS HCD to use debounced SOF-based state confirmation.
While porting this HCD to Adafruit_TinyUSB, I found that hotplug detection on the root port was unstable. The CH32 USBFS
DETECTsignal can toggle during normal traffic and around bus reset, so using it as an immediate attach/detach event can cause false remove/reattach handling.This change uses
DETECTonly as a hint and confirms port state with consecutive SOF samples.In my testing, this issue was observable in Adafruit_TinyUSB. I did not observe a regression in the standalone TinyUSB examples.
Tests:
cdc_msc_hidhost_device_info[Updates]
My Adafruit_TinyUSB repository is here: https://github.com/verylowfreq/Adafruit_TinyUSB_Arduino
Changes: USBFSH -> USBOTG_H_FS, Rename Delay_Ms and Delay_Us to __Delay_Ms and __Delay_Us (to avoid conflicts)