String: Updated mochify version in package.json#222
Open
ossdev07 wants to merge 2 commits intojprichardson:masterfrom
Open
String: Updated mochify version in package.json#222ossdev07 wants to merge 2 commits intojprichardson:masterfrom
ossdev07 wants to merge 2 commits intojprichardson:masterfrom
Conversation
PhantomJS is an unmaintained project removed optional dependency of phantomJS from mochify. Updated node version in travis.yml because earlier version used were very old. Signed-off-by: ossdev07 <ossdev@puresoftware.com>
Author
|
Ping @jprichardson @az7arul Can you please have a look at this PR. |
Collaborator
|
Thanks for the PR @ossdev07, will have a look |
Author
|
Hi @az7arul Did you find the time to review the PR? |
|
Is there any feedback on this patch? I would like to see it landed as phantomjs is unmaintained and not available on AArch64. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhantomJS is an unmaintained project, removed the optional dependency of phantomJS from mochify to use headlesschrome.
Updated node version in travis.yml because earlier version used were very old.
Signed-off-by: ossdev07 ossdev@puresoftware.com