pigeonhole-cp: never load the whole file into memory#61
Merged
Conversation
The default send now writes each box directly, reading the file one box at a time, and is reached with no flag at all; COPY becomes the opt-in --copy. The windowed SACK paths, in both directions, now work a block of ten boxes at a time rather than buffering the entire payload, so they too hold only a block in memory. Each non-final write block is an exact multiple of the box size, so the box layout is identical to a single whole-file write and the receiver reads back the same stream. Verified on the namenlos network: a twenty-thousand byte file spanning thirteen boxes round-trips byte-for-byte through --sack.
The courier COPY command now governs send by default; --no-copy opts out to the per-box streaming write. The flag, README, and smoke tests are inverted to suit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default send now writes each box directly, reading the file one box at a time, and is reached with no flag at all; COPY becomes the opt-in --copy. The windowed SACK paths, in both directions, now work a block of ten boxes at a time rather than buffering the entire payload, so they too hold only a block in memory. Each non-final write block is an exact multiple of the box size, so the box layout is identical to a single whole-file write and the receiver reads back the same stream.
Verified on the namenlos network: a twenty-thousand byte file spanning thirteen boxes round-trips byte-for-byte through --sack.