Skip to content

Conversation

@gustavobtflores
Copy link
Contributor

@gustavobtflores gustavobtflores commented Jan 22, 2026

Description

This PR changes useQueryInconsistencyInvalidator in HardwareDetails that could re-trigger continuously due to unstable navigateParams and expected count mismatches during tree/commit filtering, causing repeated invalidations/requests.

Closes #1710

@gustavobtflores gustavobtflores marked this pull request as ready for review January 22, 2026 20:57
@gustavobtflores gustavobtflores self-assigned this Jan 23, 2026
@gustavobtflores gustavobtflores added bug Something isn't working Frontend Most or all of the changes for this issue will be in the frontend code. labels Jan 23, 2026
Copy link
Collaborator

@MarceloRobert MarceloRobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but it seems like it's still duplicating some requests. On the local db, it duplicates if I access hardwareDetails through the new listing, and on the production db, it duplicates when I change the commit of a tree via the selector of the treeTable (usually happens on mainline tree that has more data), but it's not in every hardware

@gustavobtflores
Copy link
Contributor Author

Looks good, but it seems like it's still duplicating some requests. On the local db, it duplicates if I access hardwareDetails through the new listing, and on the production db, it duplicates when I change the commit of a tree via the selector of the treeTable (usually happens on mainline tree that has more data), but it's not in every hardware

It seems just useQueryInconsistencyInvalidator working as intended at first, I think we could work on having this inconsistencies fixed on another issue

@MarceloRobert
Copy link
Collaborator

It seems just useQueryInconsistencyInvalidator working as intended at first, I think we could work on having this inconsistencies fixed on another issue

Have you tested to check if it really isn't related to useQueryInconsistencyInvalidator? If so then ok, I'll create another issue and we can close this PR

@gustavobtflores
Copy link
Contributor Author

gustavobtflores commented Jan 26, 2026

It seems just useQueryInconsistencyInvalidator working as intended at first, I think we could work on having this inconsistencies fixed on another issue

Have you tested to check if it really isn't related to useQueryInconsistencyInvalidator? If so then ok, I'll create another issue and we can close this PR

yeah, I have tested it, useQueryInconsistencyInvalidator is yet triggering because sometimes divergences still occur, but as I said before, we need to work on fixing this divergences

@MarceloRobert
Copy link
Collaborator

yeah, I have tested it, useQueryInconsistencyInvalidator is yet triggering because sometimes divergences still occur, but as I said before, we need to work on fixing this divergences

Ok then. Can you create an issue for that? We always need to have issues to track what needs to be done and when a problem has been seen.

nit: in this case in your phrase you should use 'still' instead of 'yet', I've noticed it other times too 😬

Copy link
Collaborator

@MarceloRobert MarceloRobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fixes a piece of this problem puzzle

@gustavobtflores gustavobtflores added this pull request to the merge queue Jan 26, 2026
Merged via the queue into kernelci:main with commit 58abb81 Jan 26, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Frontend Most or all of the changes for this issue will be in the frontend code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple unnecessary requests being made from HardwareDetails

2 participants