Feat: use new tree listing #1709
Conversation
MarceloRobert
added
the
Frontend
- Replaces old treeListing page with new endpoint and status format - Reorganizes the routes and component files - Refactors some component parts in order to be reused between treeListings
MarceloRobert
force-pushed
the
feat/use-new-tree-listing
branch
from
b0be2f0 to
20d453b
Compare
gustavobtflores
left a comment
gustavobtflores
left a comment
There was a problem hiding this comment.
LGTM, just a small nit, i'll pre-approve
| page: formatMessage({ id: 'treeListing.treeListing' }), | ||
| gitHubLink: ( | ||
| <a | ||
| href="https://github.com/kernelci/dashboard/issues" |
There was a problem hiding this comment.
nit: I think we could move this URL into a constant at that point
Used as a link between the newer and older versions of the treeListing, should be removed after the new tree listing is stable
MarceloRobert
force-pushed
the
feat/use-new-tree-listing
branch
from
20d453b to
fcb7d4f
Compare
Adds a feature flag to select the version of the main treeListing page Closes kernelci#1559
MarceloRobert
force-pushed
the
feat/use-new-tree-listing
branch
from
ee53343 to
a09ec16
Compare
| default: | ||
| descriptionId = 'treeListing.description'; |
There was a problem hiding this comment.
what is the reason to move this to default?
There was a problem hiding this comment.
since descriptionId was declared before the switch and there was no default for the switch, it meant that descriptionId was possibly undefined, which raised a type warning/error at line 37/38
There was a problem hiding this comment.
I arrived at this file by searching the uses of PossibleMonitorPath, which was related to the PR. I understand that this file is not directly related to it, but I think it's enough to be included
| default: | ||
| return formatMessage({ id: 'treeListing.title' }); |
|
and if we have just one route being active at a time, why do we need two different routes? wouldn't be possible to have just /tree and switch behavior with the env flag? |
The idea is that since changing the feature flag is not on our hands, it is useful to still have both versions up so that we can compare them very easily anytime |
2 participants
Changes
Logic for the naming of the components/pages/routes:
How to test
Start of with data in the new treeListing table, instructions on how to populate it can be found in #1706
Check the new treeListing page and the old version. Check if the redirects are working as intended
Closes #1559