fix: communicate fixed listing filters on tree and hardware (#1924)#1955
Open
mentonin wants to merge 4 commits into
Open
fix: communicate fixed listing filters on tree and hardware (#1924)#1955mentonin wants to merge 4 commits into
mentonin wants to merge 4 commits into
Conversation
mentonin
changed the title
This filter was filtering very little in practice, and querying every lastest checkout is very cheap. Signed-off-by: Luiz Georg <luiz.georg@profusion.mobi>
…1924) Closes: kernelci#1924 Signed-off-by: Luiz Georg <luiz.georg@profusion.mobi>
Contributor
Author
|
@alanpeixinho ready for review |
alanpeixinho
added
the
Frontend
| import type { JSX } from 'react'; | ||
| import { FormattedMessage } from 'react-intl'; | ||
|
|
||
| export function FilterLabel({ days }: { days: number }): JSX.Element { |
Contributor
There was a problem hiding this comment.
Is it worth to add a new component, just for a a formatted message?
this change was out of scope and requires further investigation Signed-off-by: Luiz Georg <luiz.georg@profusion.mobi>
…rnelci#1924) feat: add a label to indicate hidden filtering filtering (kernelci#1924) Closes: kernelci#1924 Signed-off-by: Luiz Georg <luiz.georg@profusion.mobi>
| data-test-id="hardware-filter-label" | ||
| > | ||
| <FormattedMessage | ||
| id="hardwareListing.latestCheckoutFilterLabel" |
Contributor
There was a problem hiding this comment.
especially now, that we are adding this component on tree listing, the hardwareListing prefix might make us believe this component is only used in hardware page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes unnecessary time filtering from
/treesand add label to indicate time filtering to/hardware.Related Issues
/hardwarelabel incorporates changes in filtering happening in that PR