Added documentation on how to fix browser console logging components.#289
Open
jamesvl wants to merge 1 commit intoklein:masterfrom
jamesvl:master
Open
Added documentation on how to fix browser console logging components.#289jamesvl wants to merge 1 commit intoklein:masterfrom jamesvl:master
jamesvl wants to merge 1 commit intoklein:masterfrom
jamesvl:master
Conversation
Uses Klein's afterDispatch() method, which is otherwise unmentioned in the Readme file or the PHPDocs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spent a couple of hours trying to figure out why several different Monolog handlers weren't working with my site using Klein. Finally dove into the source code of each to figure out it was a
send_headers()type of issue.The fix is to use Klein's
afterDispatch()method, which is otherwise unmentioned in theReadme file or the PHPDocs.
I'm not sure of the best place for this in the docs, so chose a section that seemed to fit okay. Feel free to move it around, or leave it out entirely if the method isn't meant for general use.