-
Notifications
You must be signed in to change notification settings - Fork 619
fix: added a function to response labels #8658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: EraKin575 <[email protected]>
|
Hi @EraKin575. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: EraKin575 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: EraKin575 <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8658 +/- ##
==========================================
- Coverage 51.45% 51.43% -0.02%
==========================================
Files 400 400
Lines 25138 25146 +8
==========================================
Hits 12934 12934
- Misses 11422 11430 +8
Partials 782 782 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| ResponseStatusCode = attributekey.Int("response.statuscode") | ||
| ResponseStatusText = attributekey.String("response.statustext") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you switch these two attributekeys to be just ResponseStatusCode, and use the correct naming convention for that attribute as specified in the otel semantic conventions: https://opentelemetry.io/docs/specs/semconv/http/http-metrics/#metric-httpserverrequestduration (specifically, http.response.status_code)
|
hey @EraKin575 just following up on this PR |
|
This Pull Request is stale because it has been open for 90 days with |
Fixes ##8649
Proposed Changes
added a functions to add labels to response status in otel metric
Pre-review Checklist
Release Note
Docs