Skip to content

feat: add ko test command to build with go test -c#1407

Closed
vincent-d wants to merge 3 commits intoko-build:mainfrom
vincent-d:feat/add-ko-test-command
Closed

feat: add ko test command to build with go test -c#1407
vincent-d wants to merge 3 commits intoko-build:mainfrom
vincent-d:feat/add-ko-test-command

Conversation

@vincent-d
Copy link
Copy Markdown

Add a new command to build images with the output of go test -c.

It allows configuring build and LD flags in .ko.yaml with different values for build and test commands for a given importpath.

This is a new attempt at implementing #96 with a separate command.

Copy link
Copy Markdown
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments for now

Comment thread pkg/commands/test.go Outdated
Comment thread test/test/dummy_test.go Outdated
Add a new command to build images with the output of go test -c.

It allows configuring build and LD flags in .ko.yaml with different
values for build and test commands for a given importpath.
@vincent-d vincent-d force-pushed the feat/add-ko-test-command branch from 55a1914 to 8d932eb Compare November 5, 2024 11:03
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 4, 2025

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@StevenACoffman
Copy link
Copy Markdown
Contributor

Oh noes! This could be helpful!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2025

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 1, 2025

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@clementnuss
Copy link
Copy Markdown

what is missing in this PR?

not being able to compile test binaries with ko is a blocker. hope someone finds the time to merge this 🙏🏼

@github-actions
Copy link
Copy Markdown

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@mkilchhofer
Copy link
Copy Markdown

@vincent-d @cpanato can we reopen this?

@mkilchhofer
Copy link
Copy Markdown

Another friendly ping @vincent-d @cpanato @imjasonh - can we reopen this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants