Fix MCP interface description not updating in studio#32341
Fix MCP interface description not updating in studio#32341shirsenduda wants to merge 3 commits intolanggenius:mainfrom
Conversation
Summary of ChangesHello @shirsenduda, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where the MCP (Managed Custom Plugin) interface descriptions were not updating correctly in the studio. The fix involves implementing a global cache invalidation mechanism for all MCP tools whenever an update occurs, ensuring that the user interface consistently displays the most current information. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where the MCP interface description failed to update in the studio. The fix correctly introduces a call to invalidateAllMCPTools within the handleUpdateTools function. This ensures that the list of all MCP tools is refetched after an update, which should resolve the stale description issue. The necessary changes to support this in the component and its tests (adding mocks) have been made. Overall, the approach is sound and the implementation is clean. I have one suggestion to improve test coverage.
|
All tasks completed, CI is green. Ready for review when you have time! Thanks. |
1 similar comment
|
All tasks completed, CI is green. Ready for review when you have time! Thanks. |
|
Hi team! 👋 Branch is up to date with main, bot review was positive, and all suggestions are resolved. Could someone please approve the CI workflow run? This is my first contribution to this repo so the checks need maintainer approval to execute. Ready for review whenever you have time. Thanks! |
Important
Fixes #<issue number>.Summary
Screenshots
Checklist
make lintandmake type-check(backend) andcd web && npx lint-staged(frontend) to appease the lint gods