no fast math - #652
Merged
Merged
no fast math#652
Conversation
adamdempsey90
approved these changes
Aug 28, 2026
buechlerm
approved these changes
Aug 28, 2026
Collaborator
|
I thought fast math just used cuda intrinsic special functions but did not affect assiociativity and other things that -Ofast does. |
Collaborator
Author
Oh then perhaps I misunderstood what this flag did and we should turn it back on. At least in singularity-eos. In singularity-opac it was on for non-cuda builds which obviously wasn't desirable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
I just discovered that in the guts of our cmake we're setting essentially
-Ofast. I don't think we want to be doing that, even if it works in the code. This disables it.PR Checklist
make formatcommand after configuring withcmake.plan_historiesfolder, with a filename the same as the MR number.If preparing for a new release, in addition please check the following: