Skip to content

no fast math - #652

Merged
Yurlungur merged 1 commit into
mainfrom
jmm/no-fast-math
Aug 28, 2026
Merged

Yurlungur merged 1 commit into
mainfrom
jmm/no-fast-math

Conversation

@Yurlungur

Copy link
Copy Markdown
Collaborator

PR Summary

I just discovered that in the guts of our cmake we're setting essentially -Ofast. I don't think we want to be doing that, even if it works in the code. This disables it.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI
  • If ML was used, make sure to add a disclaimer at the top of a file indicating ML was used to assist in generating the file.
  • If Agentic AI was used, have the AI generate a "proposed changes" markdown file and store it in the plan_histories folder, with a filename the same as the MR number.

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Maintainers: ensure spackages are up to date:
    • LANL-internal team, update XCAP spackages
    • Current maintainer of upstream spackages, submit MR to spack

@Yurlungur Yurlungur self-assigned this Aug 28, 2026
@Yurlungur
Yurlungur merged commit 471547a into main Aug 28, 2026
10 checks passed
@Yurlungur
Yurlungur deleted the jmm/no-fast-math branch August 28, 2026 19:03
@dholladay00

dholladay00 commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

I thought fast math just used cuda intrinsic special functions but did not affect assiociativity and other things that -Ofast does.

@Yurlungur

Copy link
Copy Markdown
Collaborator Author

I thought fast math just used cuda intrinsic special functions but did not affect assiociativity and other things that -Ofast does.

Oh then perhaps I misunderstood what this flag did and we should turn it back on. At least in singularity-eos. In singularity-opac it was on for non-cuda builds which obviously wasn't desirable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants