Capture PDO read / write type for query events #58156
Draft
+240
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
timacdonald
commented
Dec 18, 2025
Comment on lines
-50
to
+58
| public function __construct($sql, $bindings, $time, $connection) | ||
| public function __construct($sql, $bindings, $time, $connection, $readWriteType = null) |
Member
Author
There was a problem hiding this comment.
Constructor remains backwards compatible.
Member
Author
|
cc @avosalmon 👀 |
avosalmon
reviewed
Dec 18, 2025
timacdonald
force-pushed
the
read-write-connections
branch
from
d3e3cda to
ce55981
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the read / write type to the query executed event and query exceptions for better debugging and logging.
I've found there isn't a bulletproof way to determine this with what Laravel already exposes. You can get it right in 95% of cases, but there are certain scenarios where it is impossible to know for sure if a query was against the read or write connection.
This method of tracking the last resolved PDO, although feeling a little weird, is the best way I can see of making this correct in all cases.