Skip to content

feat: Add async FDv1 streaming and data source status tracking - #464

Open
jsonbailey wants to merge 4 commits into
mainfrom
jb/sdk-2743/async-fdv1-streaming
Open

feat: Add async FDv1 streaming and data source status tracking#464
jsonbailey wants to merge 4 commits into
mainfrom
jb/sdk-2743/async-fdv1-streaming

Conversation

@jsonbailey

@jsonbailey jsonbailey commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Overview

Adds the async FDv1 streaming data source and its companion async data source status tracking, plus a new shared sans-I/O datasource_common module. This is one slice of the async Python SDK work.

What's included

  • Async FDv1 streaming data source (ldclient/impl/datasource/async_streaming.py) — driven by ld_eventsource's AsyncSSEClient and owning its own aiohttp session via make_client_session. It consumes SSE put/patch/delete events and pushes the resulting data into the async data source update sink.

  • Async data source status tracking (ldclient/impl/datasource/async_status.pyAsyncDataSourceUpdateSinkImpl and friends). The streaming source pushes data and status transitions into this update sink, so the two are runtime-coupled and land together in this slice.

  • New shared sans-I/O datasource_common module (ldclient/impl/datasource/datasource_common.py) — STREAM_ALL_PATH, sink_or_store, and parse_path. Both the sync data sources and the new async streaming source use it.

  • Behavior-preserving extraction of the sync data sources. streaming.py and polling.py are routed through datasource_common: the inline _sink_or_store/_parse_path/STREAM_ALL_PATH/ParsedPath definitions are removed in favor of importing the shared helpers, with call sites switched accordingly. No behavior change. The shared module is also needed by the upcoming async polling slice.

  • Unified status provider (sync/async). The async status provider was unified with the sync one: the redundant AsyncDataSourceStatusProviderImpl (which had no async-specific behavior — byte-identical to the sync provider apart from its sink type) is removed, and the async data system now reuses the sync DataSourceStatusProviderImpl. To let both sinks satisfy it structurally, the sync provider's update_sink parameter was widened to a small status-only Protocol (_DataSourceStatusSource). This is the same interface-segregation pattern as the PR 1b config read-protocols and mirrors the already-unified big-segment status provider. This adds a small behavior-preserving change to sync status.py.

Notes

  • The async public class carries the experimental .. caution:: block.
  • No CHANGELOG entries or version bumps (handled at release time).

Tracked internally: SDK-2743


Note

Medium Risk
New experimental async data-path code affects how flag data and change notifications are delivered; interface change on async delete return type is breaking for custom async stores.

Overview
Adds async FDv1 streaming (AsyncStreamingUpdateProcessor) that consumes SSE put/patch/delete events via AsyncSSEClient, applies updates through the config update sink (or store fallback), and reports VALID / INTERRUPTED / OFF like the sync processor—including owned aiohttp session lifecycle when no SSE factory is injected.

Introduces AsyncDataSourceUpdateSinkImpl for async stores: dependency tracking, data-source status broadcasts, and flag-change notifications on init/applied upsert/delete. AsyncFeatureStore.delete now returns bool (mirroring upsert) so stale version-rejected deletes do not fire spurious flag-change events.

Extracts shared datasource_common (STREAM_ALL_PATH, sink_or_store, parse_path) and wires sync polling and streaming through it. DataSourceStatusProviderImpl accepts a small _DataSourceStatusSource protocol so sync and async sinks share one status provider.

Broad unit coverage for the async sink and streaming processor.

Reviewed by Cursor Bugbot for commit 73977fd. Bugbot is set up for automated code reviews on this repo. Configure here.

@jsonbailey
jsonbailey marked this pull request as ready for review July 27, 2026 20:38
@jsonbailey
jsonbailey requested a review from a team as a code owner July 27, 2026 20:38
Comment thread ldclient/impl/datasource/async_streaming.py
Comment thread ldclient/impl/datasource/async_status.py Outdated
@jsonbailey
jsonbailey force-pushed the jb/sdk-2743/async-fdv1-streaming branch from 924244b to 485382a Compare July 27, 2026 21:32
except Exception as e:
error_info = DataSourceErrorInfo(DataSourceErrorKind.STORE_ERROR, 0, time.time(), str(e))
self.update_status(DataSourceState.INTERRUPTED, error_info)
raise

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Init skips store-error status update

Medium Severity

When flag-change listeners are registered, init reads prior store data via all outside the store-error try/except. A failure there propagates without recording a STORE_ERROR or moving status to INTERRUPTED, unlike the sync sink where that read is inside the monitored update path.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 485382a. Configure here.

@jsonbailey
jsonbailey force-pushed the jb/sdk-2743/async-fdv1-streaming branch from 485382a to 73977fd Compare July 27, 2026 22:00

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 73977fd. Configure here.

if self._data_source_update_sink is not None:
error_info = DataSourceErrorInfo(DataSourceErrorKind.UNKNOWN, 0, time.time(), str(e))

self._data_source_update_sink.update_status(DataSourceState.INTERRUPTED, error_info)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Store error kind overwritten

Medium Severity

When the update sink reports STORE_ERROR and re-raises, the streaming processor's broad Exception handler calls update_status again with UNKNOWN. Because a new error is supplied, status is broadcast again and the more specific STORE_ERROR kind is replaced.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 73977fd. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant