feat: Add async FDv1 streaming and data source status tracking - #464
feat: Add async FDv1 streaming and data source status tracking#464jsonbailey wants to merge 4 commits into
Conversation
924244b to
485382a
Compare
| except Exception as e: | ||
| error_info = DataSourceErrorInfo(DataSourceErrorKind.STORE_ERROR, 0, time.time(), str(e)) | ||
| self.update_status(DataSourceState.INTERRUPTED, error_info) | ||
| raise |
There was a problem hiding this comment.
Init skips store-error status update
Medium Severity
When flag-change listeners are registered, init reads prior store data via all outside the store-error try/except. A failure there propagates without recording a STORE_ERROR or moving status to INTERRUPTED, unlike the sync sink where that read is inside the monitored update path.
Reviewed by Cursor Bugbot for commit 485382a. Configure here.
485382a to
73977fd
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 73977fd. Configure here.
| if self._data_source_update_sink is not None: | ||
| error_info = DataSourceErrorInfo(DataSourceErrorKind.UNKNOWN, 0, time.time(), str(e)) | ||
|
|
||
| self._data_source_update_sink.update_status(DataSourceState.INTERRUPTED, error_info) |
There was a problem hiding this comment.
Store error kind overwritten
Medium Severity
When the update sink reports STORE_ERROR and re-raises, the streaming processor's broad Exception handler calls update_status again with UNKNOWN. Because a new error is supplied, status is broadcast again and the more specific STORE_ERROR kind is replaced.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 73977fd. Configure here.


Overview
Adds the async FDv1 streaming data source and its companion async data source status tracking, plus a new shared sans-I/O
datasource_commonmodule. This is one slice of the async Python SDK work.What's included
Async FDv1 streaming data source (
ldclient/impl/datasource/async_streaming.py) — driven byld_eventsource'sAsyncSSEClientand owning its ownaiohttpsession viamake_client_session. It consumes SSEput/patch/deleteevents and pushes the resulting data into the async data source update sink.Async data source status tracking (
ldclient/impl/datasource/async_status.py—AsyncDataSourceUpdateSinkImpland friends). The streaming source pushes data and status transitions into this update sink, so the two are runtime-coupled and land together in this slice.New shared sans-I/O
datasource_commonmodule (ldclient/impl/datasource/datasource_common.py) —STREAM_ALL_PATH,sink_or_store, andparse_path. Both the sync data sources and the new async streaming source use it.Behavior-preserving extraction of the sync data sources.
streaming.pyandpolling.pyare routed throughdatasource_common: the inline_sink_or_store/_parse_path/STREAM_ALL_PATH/ParsedPathdefinitions are removed in favor of importing the shared helpers, with call sites switched accordingly. No behavior change. The shared module is also needed by the upcoming async polling slice.Unified status provider (sync/async). The async status provider was unified with the sync one: the redundant
AsyncDataSourceStatusProviderImpl(which had no async-specific behavior — byte-identical to the sync provider apart from its sink type) is removed, and the async data system now reuses the syncDataSourceStatusProviderImpl. To let both sinks satisfy it structurally, the sync provider'supdate_sinkparameter was widened to a small status-onlyProtocol(_DataSourceStatusSource). This is the same interface-segregation pattern as the PR 1b config read-protocols and mirrors the already-unified big-segment status provider. This adds a small behavior-preserving change to syncstatus.py.Notes
.. caution::block.Tracked internally: SDK-2743
Note
Medium Risk
New experimental async data-path code affects how flag data and change notifications are delivered; interface change on async
deletereturn type is breaking for custom async stores.Overview
Adds async FDv1 streaming (
AsyncStreamingUpdateProcessor) that consumes SSEput/patch/deleteevents viaAsyncSSEClient, applies updates through the config update sink (or store fallback), and reports VALID / INTERRUPTED / OFF like the sync processor—including ownedaiohttpsession lifecycle when no SSE factory is injected.Introduces
AsyncDataSourceUpdateSinkImplfor async stores: dependency tracking, data-source status broadcasts, and flag-change notifications oninit/appliedupsert/delete.AsyncFeatureStore.deletenow returnsbool(mirroringupsert) so stale version-rejected deletes do not fire spurious flag-change events.Extracts shared
datasource_common(STREAM_ALL_PATH,sink_or_store,parse_path) and wires sync polling and streaming through it.DataSourceStatusProviderImplaccepts a small_DataSourceStatusSourceprotocol so sync and async sinks share one status provider.Broad unit coverage for the async sink and streaming processor.
Reviewed by Cursor Bugbot for commit 73977fd. Bugbot is set up for automated code reviews on this repo. Configure here.