feat(bulk-action): create reusable BulkActionToolbar component#1671
feat(bulk-action): create reusable BulkActionToolbar component#1671PARTH-TUSSLE wants to merge 3 commits into
Conversation
Signed-off-by: Parth Gartan <parthgartan26feb@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request introduces a new BulkActionToolbar component, including its unit tests and exports. The component displays a toolbar when items are selected, showing the count of selected items and an optional deselect button. The review feedback suggests avoiding hardcoded UI strings like 'Deselect ALL' and 'selected' to support internationalization (i18n). It recommends exposing these strings as configurable props with default values to maintain backward compatibility.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Signed-off-by: Parth Gartan <parthgartan26feb@gmail.com>
|
Hey @KhushamBansal , would appreciate review on this whenever you get the time. |
Signed-off-by: Parth Gartan <parthgartan26feb@gmail.com>
Notes for Reviewers
This PR implements a standardized, reusable
BulkActionToolbarcustom component in Sistent (resolving sub-issue #1665 under the #1661 umbrella).This component is designed to replace the duplicate and custom
CustomToolbarSelectheaders implemented acrossmeshery-uiand other Layer5 projects.Changes
src/custom/BulkActionToolbar/BulkActionToolbar.tsxwhich implements the selection bar containing the selected count and an optional "Deselect ALL" checkbox action button.theme.palette.background.secondary,theme.palette.background.card,theme.palette.text.default) for proper light/dark mode contrast.nullifselectedCount <= 0to hide itself automatically.src/__testing__/BulkActionToolbar.test.tsxto verify component mounting, children rendering, and click events.Integration and preview ->
When integrated with
mui-datatablesas acustomToolbarSelectreplacement, theBulkActionToolbarcleanly renders the deselect action[-], selection count (X selected), and custom action buttons (like Delete/Compare) next to the table's default selection label:This PR fixes #1665
Signed commits