fix(exports): explicitly re-export UniversalFilter so its types ship#1680
Merged
Conversation
UniversalFilter reaches the package entry only through `export * from
'./custom'`, so rollup-plugin-dts drops its declaration from the bundled
d.ts and `import { UniversalFilter } from "@sistent/sistent"` fails
type-checking even though the runtime export exists. Add an explicit
re-export (mirroring FeedbackButton, TableAction and DangerConfirmationModal)
to force UniversalFilter, FilterColumn and UniversalFilterProps into the
published declaration bundle, so consumers can drop their local d.ts
augmentations.
Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request explicitly exports UniversalFilter, FilterColumn, and UniversalFilterProps from the custom UniversalFilter module in src/index.tsx. This resolves a bundling issue with rollup-plugin-dts where nested-barrel exports were dropped from the bundled declaration file, causing type-checking failures. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
3 tasks
pull Bot
pushed a commit
to nebula-aac/sistent
that referenced
this pull request
Jul 2, 2026
…aperProps MUI v9's DrawerProps dropped the PaperProps prop in favor of the slots/slotProps pattern, so the mobile Drawer variant in UniversalFilter failed dts type-checking (TS2322) and broke `npm run build`. This is what caused the v0.21.29 release publish workflow to fail after PR layer5io#1680 merged. Mirrors the slotProps.paper pattern already used in HelperTextPopover.tsx. Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UniversalFilter reaches the package entry only through
export * from './custom', so rollup-plugin-dts drops its declaration from the bundledd.ts and
import { UniversalFilter } from "@sistent/sistent"failstype-checking even though the runtime export exists. Add an explicit
re-export (mirroring FeedbackButton, TableAction and DangerConfirmationModal)
to force UniversalFilter, FilterColumn and UniversalFilterProps into the
published declaration bundle, so consumers can drop their local d.ts
augmentations.