Skip to content

feat(UniversalFilter): add date-range picker support #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexquincy merged 2 commits into from
Jul 2, 2026
Merged

feat(UniversalFilter): add date-range picker support #1683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d03fc8
feat(UniversalFilter): add date-range picker support
leecalcote Jul 2, 2026
de2c043
ci(meshery-integration): bump pinned Meshery UI ref for date-fns dep
leecalcote Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/workflows/test-meshery-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,14 @@ jobs:
uses: actions/checkout@v6
with:
repository: meshery/meshery
# Pin to last known-good commit before the @mui/x-tree-view v8 upgrade
# that broke the TreeView import (meshery/meshery#18163).
# Remove this pin once meshery/meshery#18167 is merged.
ref: 7c3d02c91365dc776b11ffc50aab277026e86701
# Pin to the commit that added date-fns as a Meshery UI dependency
# (meshery/meshery#20416), needed because Sistent's UniversalFilter
# date-range picker now transitively requires @mui/x-date-pickers'
# AdapterDateFns, which Sistent externalizes rather than bundles.
# The prior pin (before the @mui/x-tree-view v8 upgrade that broke
# the TreeView import, meshery/meshery#18163) is no longer needed
# since meshery/meshery#18167 merged.
ref: 2d988df92ad5d336230ed9255d08a85d6bebe8fd
path: meshery
fetch-depth: 1

Expand Down
167 changes: 161 additions & 6 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
"@mui/icons-material": "^9.0.0",
"@mui/material": "^9.0.0",
"@mui/system": "^9.0.0",
"@mui/x-date-pickers": "^9.7.0",
"@reduxjs/toolkit": "^2.11.2",
"@rjsf/core": "^6.5.2",
"@rjsf/mui": "^6.5.2",
Expand All @@ -68,6 +69,7 @@
"@typescript-eslint/parser": "^8.59.1",
"commitizen": "^4.3.1",
"cz-conventional-changelog": "^3.3.0",
"date-fns": "^4.4.0",
"eslint": "10.4.0",
"eslint-plugin-react-refresh": "^0.5.2",
"globals": "^17.6.0",
Expand Down Expand Up @@ -95,11 +97,13 @@
"@mui/icons-material": "^9.0.0",
"@mui/material": "^9.0.0",
"@mui/system": "^9.0.0",
"@mui/x-date-pickers": "^9.0.0",
"@rjsf/core": "^6.0.0",
"@rjsf/mui": "^6.0.0",
"@rjsf/utils": "^6.0.0",
"@rjsf/validator-ajv8": "^6.0.0",
"@xstate/react": "^5.0.3 || ^6.0.0",
"date-fns": "^4.0.0",
"react": "^17.0.0 || ^18.0.0 || ^19.0.0",
"react-dom": "^17.0.0 || ^18.0.0 || ^19.0.0",
"xstate": "^5.25.0"
Expand All @@ -111,6 +115,12 @@
}
},
"peerDependenciesMeta": {
"@mui/x-date-pickers": {
"optional": true
},
"date-fns": {
"optional": true
},
Comment on lines +118 to +123

@gemini-code-assist gemini-code-assist Bot Jul 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

According to the repository's general rules, if a component is exported from a main entry point, its dependencies should be defined as required peer dependencies rather than optional ones. Since UniversalFilter and DateTimePicker are exported from the main entry point and statically import @mui/x-date-pickers and date-fns, marking them as optional peer dependencies will cause build-time resolution failures for consumers whose bundlers attempt to resolve these static imports. Please remove them from peerDependenciesMeta to make them required peer dependencies.

References
  1. If a component is exported from a main entry point, its dependencies should be defined as required peer dependencies rather than optional ones. This prevents build-time resolution failures for consumers who may not use the specific component but still have their bundlers attempt to resolve the static imports.

"react": {
"optional": true
},
Expand Down
Loading
Loading