Auto-refresh course unit reports on learner activity notifications#14790
Open
rtibblesbot wants to merge 3 commits into
Open
Auto-refresh course unit reports on learner activity notifications#14790rtibblesbot wants to merge 3 commits into
rtibblesbot wants to merge 3 commits into
Conversation
Contributor
Build Artifacts
Smoke test screenshot |
Member
|
What needs to be done to make this ready for review? It's still a draft currently. |
rtibbles
requested changes
Jun 5, 2026
rtibbles
left a comment
Member
There was a problem hiding this comment.
This needs to be rebased onto latest develop - also, it has not been undrafted yet, which makes me suspect that it isn't actually ready for review?
f12b1d3 to
040868b
Compare
Contributor
Author
|
Rebased onto latest upstream |
rtibbles
requested changes
Jun 11, 2026
rtibbles
left a comment
Member
There was a problem hiding this comment.
You made some sort of complaint about this being unlinked - it's still linked to an issue - please rebase!
040868b to
c4f253d
Compare
Contributor
Author
|
Rebased onto latest develop. The PR was already undrafted — it's been open (not draft) since initial submission. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The course summary page now auto-refreshes unit report data when learner activity notifications arrive for the current course session, so coaches no longer need to manually refresh to see test score updates, lesson completion progress, or status changes.
This reuses the existing
coachNotificationspolling mechanism — no new polling is introduced. Thecourse_session_idfield was already on theLearnerProgressNotificationmodel but not serialized; adding it to the API values tuple is the only backend change needed.References
Closes #14458
Reviewer guidance
To test: open a course summary page as a coach, then have a learner complete activities in that course — unit report data should update without a page refresh.
Area deserving close review: the baseline-tracking logic in
useCourseNotificationPolling.js— it captures the initialmaxNotificationTimestampon first watch invocation so that pre-existing notifications don't trigger a spurious re-fetch on page load. The composable tests cover this path, but the logic is easy to break.AI usage
This PR was implemented by Claude Code following a pre-written implementation plan. I reviewed the generated code and verified the tests pass.
@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly
How was this generated?