Skip to content

Conversation

@wbruna
Copy link
Contributor

@wbruna wbruna commented Jan 4, 2026

This is on top of #1166 just to make it easier to test.

The step numbers should probably be limited in some way?

@leejet
Copy link
Owner

leejet commented Jan 11, 2026

I believe it would be better to exclude the Python web client from this PR and keep the scope limited to server-related changes.

@leejet
Copy link
Owner

leejet commented Jan 11, 2026

The step numbers should probably be limited in some way?

I think we could limit the number of steps to a maximum value, for example, 100.

@Green-Sky
Copy link
Contributor

The step numbers should probably be limited in some way?

I think we could limit the number of steps to a maximum value, for example, 100.

For reference, I have seen distillations that use 150steps as reference.

@wbruna
Copy link
Contributor Author

wbruna commented Jan 12, 2026

For reference, I have seen distillations that use 150steps as reference.

Since this is mostly to avoid excessive processing, a better way could be combining a really high hard limit with a simple heuristic for cost. Something like number of steps * image area * batch size, first capping batch size, then the step count. (out of scope for this PR, of course)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants