Phase 1C #4: Prove expression-position helper-call preservation (Expr.internalCall via Stmt.letVar) - #2225
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_88303684-9cf1-49f3-bd64-8f5f41182e24) |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c05d5c159b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
OpenCodeReview first-pass review🔁 Incomplete — this run did not finish and will retry on the same commit. Do not count it as review coverage. OCR produced no JSON output OCR stderr highlightsOCR pilot metrics & packet coverageOCR pilot metrics
Pilot mode: advisory only. Codex Review remains the merge gate. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_00194e5c-8733-4fbc-9693-b12b6dd6a0ba) |
|
@codex review The head has advanced with a focused fix for the existing P2 thread at |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
OpenCodeReview first-pass review🔁 Incomplete — this run did not finish and will retry on the same commit. Do not count it as review coverage. OCR produced no JSON output OCR stderr highlightsOCR pilot metrics & packet coverageOCR pilot metrics
Pilot mode: advisory only. Codex Review remains the merge gate. |
Summary
Expr.internalCallthroughStmt.letVarReferences #2080 and predecessor cases #2222, #2223, and #2224.
Validation
lake build PrintAxiomspassedNote
Low Risk
Proof-only Lean additions mirroring existing call/assign catalog patterns; no runtime, auth, or compiler behavior changes.
Overview
Adds Phase 1C expression-position plumbing so
Stmt.letVarbindings ofExpr.internalCallcan feed the same helper-aware list induction as void-call and assign-call heads.Introduces
DirectInternalHelperExprCallHeadStepCatalogWithInternals, a scoped catalog ofCompiledStmtStepWithHelpersAndHelperIRWithInternalswitnesses for thoseletVarsites.stmtListDirectInternalHelperExprCallStepInterfaceWithInternals_of_headStepCatalogwalks the function body (preserving prefix scopes viaStmtOccursAtScope) and buildsStmtListExprInternalHelperStepInterfaceWithInternalswhen a catalog and a coverage premise hold (every expr-helper surface hit is exactlyletVar name (internalCall …)).Registers the new theorem in
PrintAxioms.lean(6034 → 6035 lemmas).Reviewed by Cursor Bugbot for commit ff37d06. Bugbot is set up for automated code reviews on this repo. Configure here.