refactor(dispatch): totalize guard splice/halt analysis (lane 2.2 unblock) - #2271
Merged
Conversation
…e 2.2 unblock) Replace the partial-def mutual blocks with structurally recursive total definitions (explicit case/default helpers replace the closure-based List.all/map recursion; behavior unchanged: Cases ≡ all, Dflt ≡ map). partial defs have no equation lemmas, which blocked stating any theorem about applyLockReleaseOnExits — the prerequisite for threading the guard-prologue IR lemmas (#2262) through attachNonReentrantGuard and lifting the noNonReentrant supported-fragment obligations.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_a550a889-4845-41c1-ae3d-2598c8c92d6e) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
OpenCodeReview first-pass review
⚪ OCR did not run — this diff has no OCR-supported files. Not a review outcome.
No changed files matched OCR include rules.
OCR pilot metrics & packet coverage
OCR pilot metrics
- Routing: no-supported (router-v10)
- Changed files: 0 supported / 0 total; Lean 0, trust docs 0, workflow/scripts 0, contracts 0, docs 0
- Changed lines: 0 supported; thresholds large Lean >=3 files or >800 lines
- OCR: status no-supported; comments 0; files 0; tokens 0; tool calls 0; warnings 0; duration 0s
Pilot mode: advisory only. Codex Review remains the merge gate.
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the
partial defmutual blocksyulFrameHalts/yulFrameHaltsListandspliceLockRelease/spliceLockReleaseListwith structurally recursive total definitions (explicit case/default helpers; behavior unchanged).partial defs have no equation lemmas, which made any theorem aboutapplyLockReleaseOnExitsunstatable — this was the identified blocker for threading the guard-prologue IR lemmas (#2262) throughattachNonReentrantGuardtoward liftingnoNonReentrant.Validation: full
lake build(2469 jobs) OK,make checkall passed — compiler behavior identical (feature tests overapplyLockReleaseOnExitsshapes pass unchanged).Note
Low Risk
Proof-enabling refactor with identical runtime behavior; no logic or security-path changes beyond replacing partial defs with total structural recursion.
Overview
Makes the nonreentrant lock-release helpers total so theorems about
applyLockReleaseOnExitscan be stated (unblocking guard-prologue IR lemmas towardnoNonReentrant).Replaces
partial defmutual blocks foryulFrameHalts/yulFrameHaltsListandspliceLockRelease/spliceLockReleaseListwith structurally recursivedefs, adding explicityulFrameHaltsCases,spliceLockReleaseCases, andspliceLockReleaseDflthelpers in place of.all/.map. Compiler behavior is unchanged.Reviewed by Cursor Bugbot for commit 5dfd35d. Bugbot is set up for automated code reviews on this repo. Configure here.