proof(ir): guarded-pipeline inversion lemmas (lane 2.2 pipeline closure) - #2298
Merged
Conversation
compileFunctionSpec_body_shape (the compiled body always has the loads-then-body shape, by do-chain inversion) and compileGuardedFunctionSpec_inv (the guarded pipeline is exactly compile-then-attach). With attachNonReentrantGuard_exec (#2297), any whole-contract consumer can now mechanically derive the guarded execution behavior from compileGuardedFunctionSpec = .ok fn — the pipeline-level story compile → attach → execute ≡ guarded is closed.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_de2b7d47-c508-4af9-af09-6795f7780f4d) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
OpenCodeReview first-pass review
⚪ OCR did not run — this diff has no OCR-supported files. Not a review outcome.
No changed files matched OCR include rules.
OCR pilot metrics & packet coverage
OCR pilot metrics
- Routing: no-supported (router-v10)
- Changed files: 0 supported / 0 total; Lean 0, trust docs 0, workflow/scripts 0, contracts 0, docs 0
- Changed lines: 0 supported; thresholds large Lean >=3 files or >800 lines
- OCR: status no-supported; comments 0; files 0; tokens 0; tool calls 0; warnings 0; duration 0s
Pilot mode: advisory only. Codex Review remains the merge gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the consumable chain:
compileFunctionSpec_body_shape(loads-then-body by construction, via do-chain inversion) andcompileGuardedFunctionSpec_inv(the pipeline is exactly compile-then-attach). Together withattachNonReentrantGuard_exec(#2297), the statement compile → attach → execute ≡guardedis now fully machine-checked and mechanically applicable from anycompileGuardedFunctionSpec = .okhypothesis — which is precisely what the whole-contract preservation theorems hold at their per-function sites.Validation: full
lake buildOK,make checkall passed, no sorry/admit/new axiom.Note
Low Risk
Proof-only additions with no runtime, auth, or deployment behavior changes; risk is limited to formal verification maintenance and axiom inventory bookkeeping.
Overview
Adds
Compiler/Proofs/IRGeneration/GuardedCompile.leanwith two inversion lemmas that close the guarded compilation proof chain for per-function sites in whole-contract preservation.compileFunctionSpec_body_shapeshows any successfulcompileFunctionSpecoutput hasirFn.body = genParamLoads spec.params ++ bodyStmts, by case-splitting validation, returns, and statement compilation on theExcept.okhypothesis.compileGuardedFunctionSpec_invshowscompileGuardedFunctionSpec = .ok fniff there exists an intermediateirFnwithcompileFunctionSpec = .ok irFnandattachNonReentrantGuard … = .ok fn, matching the real pipeline definition.PrintAxioms.leanimports the module and registers both theorems (public count 4382 → 4384).Reviewed by Cursor Bugbot for commit 318c110. Bugbot is set up for automated code reviews on this repo. Configure here.